> On July 11, 2011, 9 p.m., Peter Penz wrote: > > Thanks for the patch, looks good! > > Peter Penz wrote: > Committed to 4.7 (is already fixed for Dolphin 2.0 that will get merged > to master around beginning of August) > > Marcel Partap wrote: > still nothing pushed to public repo. huh? (:
Pushed to kde-baseapps to KDE/4.7 with commit c4321a1b1dead10be191b23b08f8b53983633b23 on the 12th of July. - Peter ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101919/#review4616 ----------------------------------------------------------- On July 11, 2011, 8:45 p.m., Marcel Partap wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/101919/ > ----------------------------------------------------------- > > (Updated July 11, 2011, 8:45 p.m.) > > > Review request for KDE Base Apps, David Faure and Peter Penz. > > > Summary > ------- > > At the point where m_viewModeController->setUrl(url) was invoked in current > code, the view does not yet exist because it is only created in > applyViewProperties(). Moving the call after view creation is not enough > however. The DolphinView's url itself has to be set, that implies setting the > url of the VMC. Correcting this makes the showEvent() hack unnecessary. > > > Diffs > ----- > > dolphin/src/views/dolphinview.h 48967e6 > dolphin/src/views/dolphinview.cpp 681ce74 > > Diff: http://git.reviewboard.kde.org/r/101919/diff > > > Testing > ------- > > > Thanks, > > Marcel > >
