> On Aug. 21, 2011, 10:29 a.m., David Faure wrote: > > I think this patch is almost ready, but Dawit's comment seems right about > > an improvement that should be done to it: > > > > - Move all the preemptive lookup logic from the thread's run function to > > HostInfo::lookupHost. [No need to create a thread when DNS is already > > cached].
I am a bit confused, as far as I can see, all the preemptive lookup logic is already in HostInfo::lookupHost, what more do you want me to move there? - Albert ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102179/#review5875 ----------------------------------------------------------- On Aug. 11, 2011, 10:10 p.m., Albert Astals Cid wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/102179/ > ----------------------------------------------------------- > > (Updated Aug. 11, 2011, 10:10 p.m.) > > > Review request for kdelibs and Dawit Alemayehu. > > > Summary > ------- > > Each time the terminate code triggers my Konqueror crashes, i'm substituting > the terminate for just waiting the thread to finish and we just ignoring it. > > The code has a race condition in which wait() returns false, then we switch > to the thread and m_autoDelete is still not set and thus noone will delete > the thread. I can add a mutex if you guys think this is unacceptable. > > > Diffs > ----- > > kio/kio/hostinfo.cpp 344b1d8 > > Diff: http://git.reviewboard.kde.org/r/102179/diff > > > Testing > ------- > > When the > kDebug() << "Name look up for" << hostName << "failed"; > if triggers i do not get a crash anymore. > > > Thanks, > > Albert > >
