----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102179/#review5914 -----------------------------------------------------------
This review has been submitted with commit a4871052d09eecd928666d482427abebb5f39c56 by Albert Astals Cid to branch KDE/4.7. - Commit On Aug. 11, 2011, 10:10 p.m., Albert Astals Cid wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/102179/ > ----------------------------------------------------------- > > (Updated Aug. 11, 2011, 10:10 p.m.) > > > Review request for kdelibs and Dawit Alemayehu. > > > Summary > ------- > > Each time the terminate code triggers my Konqueror crashes, i'm substituting > the terminate for just waiting the thread to finish and we just ignoring it. > > The code has a race condition in which wait() returns false, then we switch > to the thread and m_autoDelete is still not set and thus noone will delete > the thread. I can add a mutex if you guys think this is unacceptable. > > > Diffs > ----- > > kio/kio/hostinfo.cpp 344b1d8 > > Diff: http://git.reviewboard.kde.org/r/102179/diff > > > Testing > ------- > > When the > kDebug() << "Name look up for" << hostName << "failed"; > if triggers i do not get a crash anymore. > > > Thanks, > > Albert > >