----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103621/#review10274 -----------------------------------------------------------
ksmserver/FindKDeclarative.cmake <http://git.reviewboard.kde.org/r/103621/#comment8450> You can simply include(FindPackageHandleStandardArgs). The full path should not be necessary. Especially not since ${kde_cmake_module_dir} is not set in this file, and I don't know where it comes from. The prefix "kde_" makes it look like it comes from FindKDE4Internal.cmake, but there everything has the prefix "KDE4_". Everything else is internal and should not be used. ksmserver/FindKDeclarative.cmake <http://git.reviewboard.kde.org/r/103621/#comment8451> You should also add a set(KDECLARATIVE_INCLUDE_DIRS ${KDECLARATIVE_INCLUDE_DIR}), as recommended in the cmake module readme.txt, see http://www.cmake.org/cgi-bin/viewcvs.cgi/Modules/readme.txt?root=CMake&view=markup ksmserver/FindKDeclarative.cmake <http://git.reviewboard.kde.org/r/103621/#comment8449> KDECLARATIVE_LIBRARIES doesn't have to be marked as advanced, since it is not a cache variable. (the other two variables are the result variables from find_path() and find_library(), so they are put automatically in the cache, and so should be marked as advanced, as done here) - Alexander Neundorf On Jan. 30, 2012, 5:08 p.m., Lamarque Vieira Souza wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/103621/ > ----------------------------------------------------------- > > (Updated Jan. 30, 2012, 5:08 p.m.) > > > Review request for KDE Base Apps and KDE Runtime. > > > Description > ------- > > Port shutdown dialog to QML. Two QML themes are included: default, which > mimics the current shutdown dialog look & feel, and contour, which is used in > Plasma Active. > > > This addresses bugs 216853 and 216853. > http://bugs.kde.org/show_bug.cgi?id=216853 > http://bugs.kde.org/show_bug.cgi?id=216853 > > > Diffs > ----- > > ksmserver/CMakeLists.txt 295b96e > ksmserver/Copyright.txt PRE-CREATION > ksmserver/FindKDeclarative.cmake PRE-CREATION > ksmserver/Messages.sh 0aa8bab > ksmserver/shutdown.cpp 7fd1e11 > ksmserver/shutdowndlg.h e5f0942 > ksmserver/shutdowndlg.cpp a09a1a7 > ksmserver/themes/contour/ContourButton.qml PRE-CREATION > ksmserver/themes/contour/main.qml PRE-CREATION > ksmserver/themes/contour/metadata.desktop PRE-CREATION > ksmserver/themes/contour/screenshot.png PRE-CREATION > ksmserver/themes/default/ContextMenu.qml PRE-CREATION > ksmserver/themes/default/KSMButton.qml PRE-CREATION > ksmserver/themes/default/MenuItem.qml PRE-CREATION > ksmserver/themes/default/helper.js PRE-CREATION > ksmserver/themes/default/main.qml PRE-CREATION > ksmserver/themes/default/metadata.desktop PRE-CREATION > ksmserver/themes/default/screenshot.png PRE-CREATION > > Diff: http://git.reviewboard.kde.org/r/103621/diff/diff > > > Testing > ------- > > Works in Plasma Active Two using MeeGo image and KDE SC 4.8. It does not work > in 4.7.x because the default theme requires kde-runtime 4.8's declarative > imports. > > TODO: > > . test right to left language support. > > > Screenshots > ----------- > > > http://git.reviewboard.kde.org/r/103621/s/400/ > New version with label accelerator working > http://git.reviewboard.kde.org/r/103621/s/407/ > > > Thanks, > > Lamarque Vieira Souza > >