> On Feb. 6, 2012, 9:38 p.m., Alexander Neundorf wrote: > > Good from my POV (cmake stuff). > > Christoph Feck wrote: > UI-wise looks also fine. Was there anything else we needed to do? If not, > merge to master. Thanks, you rock!
Alex, we need this FindKdeclarative.cmake in kdelibs, and not in this repository since it is used by almost every single KDE Mobile Applications in theory (one common use case is the localization)... Are you fine with this "quick" solution, if I push it against KDE/4.8 ? I do not personally have time for learning this *Config.cmake, and we would not like to hard code "kdeclarative" into the target_link_libraries either. If someone felt like volunteering with a proper config file, I would be happy. :-) - Laszlo ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103621/#review10379 ----------------------------------------------------------- On Feb. 4, 2012, 2:04 p.m., Lamarque Vieira Souza wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/103621/ > ----------------------------------------------------------- > > (Updated Feb. 4, 2012, 2:04 p.m.) > > > Review request for KDE Base Apps and KDE Runtime. > > > Description > ------- > > Port shutdown dialog to QML. Two QML themes are included: default, which > mimics the current shutdown dialog look & feel, and contour, which is used in > Plasma Active. > > > This addresses bugs 216853 and 216853. > http://bugs.kde.org/show_bug.cgi?id=216853 > http://bugs.kde.org/show_bug.cgi?id=216853 > > > Diffs > ----- > > ksmserver/CMakeLists.txt 295b96e > ksmserver/Copyright.txt PRE-CREATION > ksmserver/FindKDeclarative.cmake PRE-CREATION > ksmserver/Messages.sh 0aa8bab > ksmserver/shutdown.cpp 7fd1e11 > ksmserver/shutdowndlg.h e5f0942 > ksmserver/shutdowndlg.cpp a09a1a7 > ksmserver/themes/contour/ContourButton.qml PRE-CREATION > ksmserver/themes/contour/main.qml PRE-CREATION > ksmserver/themes/contour/metadata.desktop PRE-CREATION > ksmserver/themes/contour/screenshot.png PRE-CREATION > ksmserver/themes/default/ContextMenu.qml PRE-CREATION > ksmserver/themes/default/KSMButton.qml PRE-CREATION > ksmserver/themes/default/MenuItem.qml PRE-CREATION > ksmserver/themes/default/helper.js PRE-CREATION > ksmserver/themes/default/main.qml PRE-CREATION > ksmserver/themes/default/metadata.desktop PRE-CREATION > ksmserver/themes/default/screenshot.png PRE-CREATION > > Diff: http://git.reviewboard.kde.org/r/103621/diff/ > > > Testing > ------- > > Works in Plasma Active Two using MeeGo image and KDE SC 4.8. It does not work > in 4.7.x because the default theme requires kde-runtime 4.8's declarative > imports. > > TODO: > > . test right to left language support. > > > Screenshots > ----------- > > > http://git.reviewboard.kde.org/r/103621/s/400/ > New version with label accelerator working > http://git.reviewboard.kde.org/r/103621/s/407/ > > > Thanks, > > Lamarque Vieira Souza > >
