----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104624/#review12612 -----------------------------------------------------------
kio/kio/dataprotocol.cpp <http://git.reviewboard.kde.org/r/104624/#comment9863> This looks wrong. If you call url.path(), you have a decoded string, so no need to call fromPercentEncoding on it. kio/kio/dataprotocol.cpp <http://git.reviewboard.kde.org/r/104624/#comment9864> If data_offset is now always 0, this if can never pass, can it? Or maybe if raw_url_len is 0, but in any case this could be simplified to if (raw_url_len == 0)... - David Faure On April 16, 2012, 8:26 p.m., Rolf Eike Beer wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/104624/ > ----------------------------------------------------------- > > (Updated April 16, 2012, 8:26 p.m.) > > > Review request for kdelibs. > > > Description > ------- > > The testcases at http://greenbytes.de/tech/tc/datauri/ show that we > incorrectly take the fragment (that's everything starting with the #) in a > link containing a data URL as part of the URL. Fix it ;) > > > Diffs > ----- > > kio/kio/dataprotocol.cpp ea95de4 > kio/tests/dataprotocoltest.cpp 6d7f1c7 > > Diff: http://git.reviewboard.kde.org/r/104624/diff/ > > > Testing > ------- > > Old unittests still pass, new ones now also. > > > Thanks, > > Rolf Eike Beer > >
