> On April 17, 2012, 7:47 p.m., David Faure wrote: > > kio/kio/dataprotocol.cpp, line 181 > > <http://git.reviewboard.kde.org/r/104624/diff/1/?file=56827#file56827line181> > > > > This looks wrong. If you call url.path(), you have a decoded string, so > > no need to call fromPercentEncoding on it.
You are right. I removed the fromPercentEncoding() and everything is fine. > On April 17, 2012, 7:47 p.m., David Faure wrote: > > kio/kio/dataprotocol.cpp, line 189 > > <http://git.reviewboard.kde.org/r/104624/diff/1/?file=56827#file56827line189> > > > > If data_offset is now always 0, this if can never pass, can it? Or > > maybe if raw_url_len is 0, but in any case this could be simplified to if > > (raw_url_len == 0)... Yes, changed to (raw_url_len == 0) - Rolf Eike ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104624/#review12612 ----------------------------------------------------------- On April 16, 2012, 8:26 p.m., Rolf Eike Beer wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/104624/ > ----------------------------------------------------------- > > (Updated April 16, 2012, 8:26 p.m.) > > > Review request for kdelibs. > > > Description > ------- > > The testcases at http://greenbytes.de/tech/tc/datauri/ show that we > incorrectly take the fragment (that's everything starting with the #) in a > link containing a data URL as part of the URL. Fix it ;) > > > Diffs > ----- > > kio/kio/dataprotocol.cpp ea95de4 > kio/tests/dataprotocoltest.cpp 6d7f1c7 > > Diff: http://git.reviewboard.kde.org/r/104624/diff/ > > > Testing > ------- > > Old unittests still pass, new ones now also. > > > Thanks, > > Rolf Eike Beer > >
