----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104243/#review12765 -----------------------------------------------------------
Hmm, you may have missed my reply on IRC, making this languish in the ether: I meant number of shift/reduce conflicts in the parser, as reported by bison. I am ashamed to admit that I am not able to detect LALR parsing ambiguities by inspection.. - Maks Orlovich On March 12, 2012, 9:03 p.m., Bernd Buschinski wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/104243/ > ----------------------------------------------------------- > > (Updated March 12, 2012, 9:03 p.m.) > > > Review request for kdelibs. > > > Description > ------- > > KJS/Grammar: Introduce new non-terminal IdentifierName, > which allows keywords to be used as PropertyName, in Memberexps and CallExpr. > (but not yet enum,export,extends, super, because they have the same value > RESERVED) > > > Diffs > ----- > > kjs/grammar.h 2a006df > kjs/grammar.cpp 32dbeae > kjs/grammar.y d5e835f > > Diff: http://git.reviewboard.kde.org/r/104243/diff/ > > > Testing > ------- > > Tested with ecmascript262, all keyword cases pass now, except the reserved > ones > > > Thanks, > > Bernd Buschinski > >
