> On Aug. 14, 2012, 3:44 p.m., Frank Reininghaus wrote: > > dolphin/src/kitemviews/kitemlistviewaccessible.h, line 143 > > <http://git.reviewboard.kde.org/r/105972/diff/3/?file=77712#file77712line143> > > > > This class isn't needed any more, is it?
This class is needed since the accessibility interface tree, as is shown by Accerciser in dolphin will then never expand upto the Table Interface we wrote. Basically QAI is present for the QWidgets and a11y clients can navigate their children. Since the KItemListView is a QGraphicsWidget, so accerciser is unable to reach it directly. The class in question, KItemListContainerA11y provides this connection to KItemListView. - Amandeep ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105972/#review17396 ----------------------------------------------------------- On Aug. 15, 2012, 7:12 a.m., Amandeep Singh wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/105972/ > ----------------------------------------------------------- > > (Updated Aug. 15, 2012, 7:12 a.m.) > > > Review request for Dolphin, KDE Base Apps and KDE Accessibility. > > > Description > ------- > > Added Accessibility Interfaces for Dolphin Views & Widgets, to make it > accessible. > 2 New files added in dolphin/ src/ kitemviews/ kitemlistviewaccessible.* that > contain the three new classes. > > > Diffs > ----- > > dolphin/src/CMakeLists.txt afc190f > dolphin/src/kitemviews/kitemlistcontroller.cpp 88f5d9f > dolphin/src/kitemviews/kitemlistview.h 5723b9a > dolphin/src/kitemviews/kitemlistview.cpp 72b3fd8 > dolphin/src/kitemviews/kitemlistviewaccessible.h PRE-CREATION > dolphin/src/kitemviews/kitemlistviewaccessible.cpp PRE-CREATION > dolphin/src/kitemviews/private/kitemlistviewlayouter.h da5bd1d > dolphin/src/tests/CMakeLists.txt 3f906d1 > > Diff: http://git.reviewboard.kde.org/r/105972/diff/ > > > Testing > ------- > > Focus-tracking tested with KMag / KWin. > > > Thanks, > > Amandeep Singh > >
