> On Aug. 14, 2012, 3:44 p.m., Frank Reininghaus wrote: > > dolphin/src/kitemviews/kitemlistviewaccessible.h, line 143 > > <http://git.reviewboard.kde.org/r/105972/diff/3/?file=77712#file77712line143> > > > > This class isn't needed any more, is it? > > Amandeep Singh wrote: > This class is needed since the accessibility interface tree, as is shown > by Accerciser in dolphin will then never expand upto the Table Interface we > wrote. Basically QAI is present for the QWidgets and a11y clients can > navigate their children. > > Since the KItemListView is a QGraphicsWidget, so accerciser is unable to > reach it directly. The class in question, KItemListContainerA11y provides > this connection to KItemListView. > > Frank Reininghaus wrote: > OK, but then I wonder if my previous statement that the changes you had > proposed in KItemListContainer in the first version of your patch are not > needed is correct. I'm not familiar with QAccessible, but I can't see how any > code is supposed to construct or call methods of a > KItemListContainerAccessible (which is required if I understand you correctly > because the QAccessible framwork cannot reach KItemListViewAccessible > directly) in the current version of your patch. But maybe I got something > wrong. > > In other words: have you checked that the current version of the patch is > still working correctly? > > Frederik Gladhorn wrote: > The way the accessible objects are constructed is in > QAccessible::queryAccessibleInterface. There are factories (and this patch > adds a new one for the KItemListContainerA11y and KItemListViewAccessible) > that get queried. It works by using QObject introspection and comparing the > class name to what the factories support.
Yes, I see. When I wrote the question above, the factory function only created a KItemListViewAccessible, not a KItemListContainerAccessible. Thanks for fixing this. - Frank ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105972/#review17396 ----------------------------------------------------------- On Aug. 17, 2012, 11:20 a.m., Amandeep Singh wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/105972/ > ----------------------------------------------------------- > > (Updated Aug. 17, 2012, 11:20 a.m.) > > > Review request for Dolphin, KDE Base Apps and KDE Accessibility. > > > Description > ------- > > Added Accessibility Interfaces for Dolphin Views & Widgets, to make it > accessible. > 2 New files added in dolphin/ src/ kitemviews/ kitemlistviewaccessible.* that > contain the three new classes. > > > Diffs > ----- > > dolphin/src/CMakeLists.txt afc190f > dolphin/src/kitemviews/kitemlistcontroller.cpp 88f5d9f > dolphin/src/kitemviews/kitemlistview.h 5723b9a > dolphin/src/kitemviews/kitemlistview.cpp 72b3fd8 > dolphin/src/kitemviews/kitemlistviewaccessible.h PRE-CREATION > dolphin/src/kitemviews/kitemlistviewaccessible.cpp PRE-CREATION > dolphin/src/kitemviews/private/kitemlistviewlayouter.h da5bd1d > dolphin/src/tests/CMakeLists.txt 3f906d1 > > Diff: http://git.reviewboard.kde.org/r/105972/diff/ > > > Testing > ------- > > Focus-tracking tested with KMag / KWin. > > > Thanks, > > Amandeep Singh > >
