----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106300/#review18386 -----------------------------------------------------------
Nice work, much requested. See issues below. kimgio/webp.cpp <http://git.reviewboard.kde.org/r/106300/#comment14513> We need to be more verbose here, it has to state the versions, and a pointer where to get the license text. Please check the KDE licensing page for correct texts. kimgio/webp.cpp <http://git.reviewboard.kde.org/r/106300/#comment14514> Needs to check image.isValid() before writing data via scanLine() pointers. The allocation may fail because of too large width*height. Additionally, I would like the loader to return a Format_RGB32 image, when the data did not contain an alpha component. kimgio/webp.cpp <http://git.reviewboard.kde.org/r/106300/#comment14515> Same here, should handle pure RGB case. kimgio/webp.cpp <http://git.reviewboard.kde.org/r/106300/#comment14516> "header.size() == 12 && ..." Otherwise, it would return true for the file "RIFFWEBP" :) - Christoph Feck On Sept. 1, 2012, 8:33 a.m., Martin Koller wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/106300/ > ----------------------------------------------------------- > > (Updated Sept. 1, 2012, 8:33 a.m.) > > > Review request for kdelibs. > > > Description > ------- > > This patch adds support for the new Google invented WebP image format. See > https://developers.google.com/speed/webp/?hl=ru > > The patch is missing a cmake rule to make it optional, though, but I sent a > mail to KDE-core list in the hope someone knows... > > > This addresses bug 267365. > http://bugs.kde.org/show_bug.cgi?id=267365 > > > Diffs > ----- > > kimgio/webp.cpp PRE-CREATION > kimgio/webp.desktop PRE-CREATION > kimgio/webp.h PRE-CREATION > > Diff: http://git.reviewboard.kde.org/r/106300/diff/ > > > Testing > ------- > > some KDE apps, including read/write with a modified kolourpaint (to be able > to change the quality) > > > Thanks, > > Martin Koller > >