----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106300/#review18829 -----------------------------------------------------------
Looks good. I started writing such a plugin myself sometime back, so excuse my rather specific comments. kimgio/webp.cpp <http://git.reviewboard.kde.org/r/106300/#comment14924> This seems needlessly explicit, why not just copy the whole block into QImage? kimgio/webp.cpp <http://git.reviewboard.kde.org/r/106300/#comment14925> Same as for decoding. Why copy it color by color like this, when the formats are identical? kimgio/webp.cpp <http://git.reviewboard.kde.org/r/106300/#comment14926> Not really required, but it would be nice to support the Size option. It is quite often used, and should be available through WebPGetInfo() kimgio/webp.cpp <http://git.reviewboard.kde.org/r/106300/#comment14927> Should it also require "VP8 " in byte 12 to 16, to protect against new unsupported versions? For some reason I have code that checks the file is atleast 32 bytes long, I think that is because it is what WePGetInfo requires. - Allan Sandfeld Jensen On Sept. 1, 2012, 9:23 p.m., Martin Koller wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/106300/ > ----------------------------------------------------------- > > (Updated Sept. 1, 2012, 9:23 p.m.) > > > Review request for kdelibs. > > > Description > ------- > > This patch adds support for the new Google invented WebP image format. See > https://developers.google.com/speed/webp/?hl=ru > > The patch is missing a cmake rule to make it optional, though, but I sent a > mail to KDE-core list in the hope someone knows... > > > This addresses bug 267365. > http://bugs.kde.org/show_bug.cgi?id=267365 > > > Diffs > ----- > > kimgio/CMakeLists.txt 26329c0 > kimgio/webp.cpp PRE-CREATION > kimgio/webp.desktop PRE-CREATION > kimgio/webp.h PRE-CREATION > mimetypes/kde.xml a82b87c > > Diff: http://git.reviewboard.kde.org/r/106300/diff/ > > > Testing > ------- > > some KDE apps, including read/write with a modified kolourpaint (to be able > to change the quality) > > > Thanks, > > Martin Koller > >