-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107358/
-----------------------------------------------------------
(Updated Nov. 20, 2012, 7:34 p.m.)
Review request for kdelibs.
Changes
-------
Added comment explaining the cache issue and the update problem.
Only one hash lookup now.
Added a counter to clear the cache from time to time (depending on the number
of requests, not time).
If you think this counter is not necessary, I can remove it.
Description
-------
Does not fix the bugs (I'll not mark them as fixed), but makes them much harder
to reproduce.
Just use a static QHash most of the time instead of a blocking Dbus call.
This addresses bugs 306338 and 307973.
http://bugs.kde.org/show_bug.cgi?id=306338
http://bugs.kde.org/show_bug.cgi?id=307973
Diffs (updated)
-----
kdecore/services/kmimetype.cpp 955bf62
Diff: http://git.reviewboard.kde.org/r/107358/diff/
Testing
-------
In my tests, there are more than 5 thousands requests for a favicon answered by
the local cache vs. less than new 50 favicons inserted.
Thanks,
Jaime Torres Amate
