----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107358/#review22327 -----------------------------------------------------------
This review has been submitted with commit 6da17ae80bd8cb5453e1b43b7b9e5da989c30ada by Jaime Torres to branch KDE/4.10. - Commit Hook On Nov. 20, 2012, 7:34 p.m., Jaime Torres Amate wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/107358/ > ----------------------------------------------------------- > > (Updated Nov. 20, 2012, 7:34 p.m.) > > > Review request for kdelibs. > > > Description > ------- > > Does not fix the bugs (I'll not mark them as fixed), but makes them much > harder to reproduce. > Just use a static QHash most of the time instead of a blocking Dbus call. > > > This addresses bugs 306338 and 307973. > http://bugs.kde.org/show_bug.cgi?id=306338 > http://bugs.kde.org/show_bug.cgi?id=307973 > > > Diffs > ----- > > kdecore/services/kmimetype.cpp 955bf62 > > Diff: http://git.reviewboard.kde.org/r/107358/diff/ > > > Testing > ------- > > In my tests, there are more than 5 thousands requests for a favicon answered > by the local cache vs. less than new 50 favicons inserted. > > > Thanks, > > Jaime Torres Amate > >
