----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107356/#review26883 -----------------------------------------------------------
I see this has a ship it but marked as uncommited. Was it commited and you forgot to close the request or is still uncommited? - Albert Astals Cid On Nov. 17, 2012, 10:31 a.m., Thomas Fischer wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/107356/ > ----------------------------------------------------------- > > (Updated Nov. 17, 2012, 10:31 a.m.) > > > Review request for kdelibs. > > > Description > ------- > > According to the latest Qt documentation, there is no PageSize enum in > QPrinter, only a PaperSize enum. > > BTW, wouldn't it be a good idea for KDE5 (not to break anything now, but add > a "//KDE5" comment) to use QPrinter's enum directly instead of an int and to > rename the functions to paperSize() and setPaperSize(..), respectively? > > > Diffs > ----- > > kdecore/localization/klocale.h cdbc3d3 > > Diff: http://git.reviewboard.kde.org/r/107356/diff/ > > > Testing > ------- > > > Thanks, > > Thomas Fischer > >
