> On Feb. 7, 2013, 9:14 p.m., Albert Astals Cid wrote: > > I see this has a ship it but marked as uncommited. Was it commited and you > > forgot to close the request or is still uncommited? > > Thomas Fischer wrote: > I am quite new to git, so I hope the push I just made is correct: > http://commits.kde.org/kdelibs/2a3c82cdf000db3f888e072aab1e1624d2d3861f
You can feed the commit hooks with the following keyword in the future (i.e. by putting at the end of the commit message): "REVIEW: 107356" The reviewboard entry will be marked as submitted automatically for you. - Laszlo ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107356/#review26883 ----------------------------------------------------------- On Nov. 17, 2012, 10:31 a.m., Thomas Fischer wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/107356/ > ----------------------------------------------------------- > > (Updated Nov. 17, 2012, 10:31 a.m.) > > > Review request for kdelibs. > > > Description > ------- > > According to the latest Qt documentation, there is no PageSize enum in > QPrinter, only a PaperSize enum. > > BTW, wouldn't it be a good idea for KDE5 (not to break anything now, but add > a "//KDE5" comment) to use QPrinter's enum directly instead of an int and to > rename the functions to paperSize() and setPaperSize(..), respectively? > > > Diffs > ----- > > kdecore/localization/klocale.h cdbc3d3 > > Diff: http://git.reviewboard.kde.org/r/107356/diff/ > > > Testing > ------- > > > Thanks, > > Thomas Fischer > >
