-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110315/#review32063
-----------------------------------------------------------



kdm/kfrontend/genkdmconf.c
<http://git.reviewboard.kde.org/r/110315/#comment23883>

    i wonder whether this condition is actually useful. i originally added it 
because some *BSDs (iirc) had an incompatible adduser command. the situation 
may be entirely different for useradd.


- Oswald Buddenhagen


On May 5, 2013, 10:53 a.m., Raymond Wooninck wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110315/
> -----------------------------------------------------------
> 
> (Updated May 5, 2013, 10:53 a.m.)
> 
> 
> Review request for kde-workspace, Luboš Luňák and Oswald Buddenhagen.
> 
> 
> Description
> -------
> 
> This patch allows for the recognition of an openSUSE/SUSE installation and 
> utilizes the correct tools to create the kdm user and group. This would fix 
> an very old situation where at this moment only debian installations were 
> recognized and properly handled.
> 
> The code follows the coding for debian
> 
> 
> Diffs
> -----
> 
>   kdm/kfrontend/genkdmconf.c 69b42f1 
> 
> Diff: http://git.reviewboard.kde.org/r/110315/diff/
> 
> 
> Testing
> -------
> 
> Testing has been done on a couple of openSUSE systems and here the user and 
> group were properly created and no more error messages were shown. 
> 
> 
> Thanks,
> 
> Raymond Wooninck
> 
>

Reply via email to