> On May 5, 2013, 11:41 a.m., Oswald Buddenhagen wrote: > > kdm/kfrontend/genkdmconf.c, line 2112 > > <http://git.reviewboard.kde.org/r/110315/diff/4-5/?file=142255#file142255line2112> > > > > and now you ignored the warning from the compiler. ;)
Apologies, my C/C++ knowledge is quite rusty :-) - Raymond ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110315/#review32067 ----------------------------------------------------------- On May 5, 2013, 12:02 p.m., Raymond Wooninck wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/110315/ > ----------------------------------------------------------- > > (Updated May 5, 2013, 12:02 p.m.) > > > Review request for kde-workspace, Luboš Luňák and Oswald Buddenhagen. > > > Description > ------- > > This patch allows for the recognition of an openSUSE/SUSE installation and > utilizes the correct tools to create the kdm user and group. This would fix > an very old situation where at this moment only debian installations were > recognized and properly handled. > > The code follows the coding for debian > > > Diffs > ----- > > kdm/kfrontend/genkdmconf.c 69b42f1 > > Diff: http://git.reviewboard.kde.org/r/110315/diff/ > > > Testing > ------- > > Testing has been done on a couple of openSUSE systems and here the user and > group were properly created and no more error messages were shown. > > > Thanks, > > Raymond Wooninck > >
