----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110390/#review32419 -----------------------------------------------------------
Looks ok to me, but I can't test since I don't have pulse installed. (and I'm not at home) Perhaps Colin (coling) or Harald (apachelogger) could look into it. Anyway, I don't see anything that can be wrong :) - Casian Andrei On May 11, 2013, 8:05 p.m., Jan Grulich wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/110390/ > ----------------------------------------------------------- > > (Updated May 11, 2013, 8:05 p.m.) > > > Review request for KDE Runtime and Casian Andrei. > > > Description > ------- > > This patch fixes a problem in Phonon KCM which is always set as changed when > using PulseAudio. Previous solution emits ready() signal when some parts of > AudioSetup are not initialized yet. And changed() signal is connected to soon > so that's the reason why this KCM is always set as changed. > > > Diffs > ----- > > phonon/kcm/audiosetup.cpp 35dc4ca > phonon/kcm/main.cpp 5d75cba > > Diff: http://git.reviewboard.kde.org/r/110390/diff/ > > > Testing > ------- > > > Thanks, > > Jan Grulich > >
