-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110390/#review33211
-----------------------------------------------------------


This review has been submitted with commit 
7f5a51e38df0bf432487bb0df11670f92cb78905 by Jan Grulich to branch KDE/4.10.

- Commit Hook


On May 13, 2013, 8:10 a.m., Jan Grulich wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110390/
> -----------------------------------------------------------
> 
> (Updated May 13, 2013, 8:10 a.m.)
> 
> 
> Review request for KDE Runtime, Casian Andrei, Colin Guthrie, and Harald 
> Sitter.
> 
> 
> Description
> -------
> 
> This patch fixes a problem in Phonon KCM which is always set as changed when 
> using PulseAudio. Previous solution emits ready() signal when some parts of 
> AudioSetup are not initialized yet. And changed() signal is connected to soon 
> so that's the reason why this KCM is always set as changed.
> 
> 
> Diffs
> -----
> 
>   phonon/kcm/audiosetup.cpp 35dc4ca 
>   phonon/kcm/main.cpp 5d75cba 
> 
> Diff: http://git.reviewboard.kde.org/r/110390/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jan Grulich
> 
>

Reply via email to