> On July 12, 2012, 4:17 p.m., David Faure wrote: > > Looks good. For master only, though, given feature+message freeze in 4.9. > > Kai Uwe Broulik wrote: > Totally forgot to commit this :( Will do for master (4.10) once my ssh > key for my new notebook got imported. > > Albert Astals Cid wrote: > I see this has a ship it but marked as uncommited. Was it commited and > you forgot to close the request or is still uncommited? > > Kai Uwe Broulik wrote: > Haven't come around to rebase the patch. Will do a new one next week, no > time before Monday.
8 months since "next week", how is it going? - Albert ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105304/#review15735 ----------------------------------------------------------- On June 20, 2012, 12:06 a.m., Kai Uwe Broulik wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/105304/ > ----------------------------------------------------------- > > (Updated June 20, 2012, 12:06 a.m.) > > > Review request for KDE Base Apps. > > > Repository: kde-baseapps > > > Description > ------- > > As somebody who loves bash scripting but also wants to have a nice > userfriendly graphical "interface" for those scripts, I excessively use > kdialog. > In a new project I am working on, I need the detailedsorry thing in > KMessageBox, so I can provide a simple error message "could not launch xyz" > while allowing detailed error information such as "directory xyz does not > exist" in an expandable Details box. > This patch adds this functionality to kdialog. > Usage: > kdialog --detailedsorry "error message" "what should be in the details > section" > also works with detailederror > > [I am volunteering for an update of the respective Wiki page on techbase > http://techbase.kde.org/index.php?title=Development/Tutorials/Shell_Scripting_with_KDE_Dialogs_%28de%29 > as well. Those screenshots date back to KDE 3 and early KDE 4 times ;) ] > > > Diffs > ----- > > kdialog/kdialog.cpp ca2df2f > > Diff: http://git.reviewboard.kde.org/r/105304/diff/ > > > Testing > ------- > > Tested and works. Works with linebreaks and other parameters as well. > > > Screenshots > ----------- > > a sample message > http://git.reviewboard.kde.org/r/105304/s/606/ > > > Thanks, > > Kai Uwe Broulik > >