----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114910/#review47049 -----------------------------------------------------------
briefly looking at the bug - wouldn't it be better to only cause a full parent repaint when adding/removing an (fdo) icon? - Thomas Lübking On Jan. 8, 2014, 8:59 a.m., Dmitry Ivanov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/114910/ > ----------------------------------------------------------- > > (Updated Jan. 8, 2014, 8:59 a.m.) > > > Review request for kde-workspace and Plasma. > > > Bugs: 317066 > http://bugs.kde.org/show_bug.cgi?id=317066 > > > Repository: kde-workspace > > > Description > ------- > > It is a proposed fix for bug 317066. The fix is a very simple one-liner > setting FullViewportUpdate mode for FdoGraphicsWidget. I'm aware > FullViewportUpdate has negative performance impact but I also know it > efficiently leaves out any graphical glitches happening due to no repaint of > widget when necessary (which is what the bug is about). I have tested my > solution for a couple of days: the bug no longer reproduced and I also didn't > see any noticeable performance problems. I'm still not sure what I propose is > acceptable since it may seem like a hack to more experienced developers, > however I just didn't want my patch attempt to get lost and forgotten in the > bugzilla. Please have a look and decide whether the patch is good enough to > be applied to the next bugfixing release of KDE 4.x series, thank you. > > > Diffs > ----- > > plasma/generic/applets/systemtray/protocols/fdo/fdographicswidget.cpp > 1baa23daa5abd5deaab986dc65cec7b9d1031e6c > > Diff: https://git.reviewboard.kde.org/r/114910/diff/ > > > Testing > ------- > > I rebuilt plasma_applet_systemtray.so with the patch and replaced the package > version with it (I'm on Linux Mint 16 KDE, x86_64, KDE 4.11.3). So far I can > no longer reproduce bug 317066 and I don't see any noticeable performance > problems of system tray applet. > > > Thanks, > > Dmitry Ivanov > >
