-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114910/
-----------------------------------------------------------
(Updated Jan. 8, 2014, 8:25 p.m.)
Review request for kde-workspace and Plasma.
Changes
-------
Uploaded a modified working patch which is no longer a one-line addition inside
FdoGraphicsWidget::paint method but a dozen of new lines setting the full
viewport update mode for parent view of FdoGraphicsWidget inside its
constructor. So far it is the most proper working solution I can come up with.
Bugs: 317066
http://bugs.kde.org/show_bug.cgi?id=317066
Repository: kde-workspace
Description
-------
It is a proposed fix for bug 317066. The fix is a very simple one-liner setting
FullViewportUpdate mode for FdoGraphicsWidget. I'm aware FullViewportUpdate has
negative performance impact but I also know it efficiently leaves out any
graphical glitches happening due to no repaint of widget when necessary (which
is what the bug is about). I have tested my solution for a couple of days: the
bug no longer reproduced and I also didn't see any noticeable performance
problems. I'm still not sure what I propose is acceptable since it may seem
like a hack to more experienced developers, however I just didn't want my patch
attempt to get lost and forgotten in the bugzilla. Please have a look and
decide whether the patch is good enough to be applied to the next bugfixing
release of KDE 4.x series, thank you.
Diffs (updated)
-----
plasma/generic/applets/systemtray/protocols/fdo/fdographicswidget.cpp 1baa23d
Diff: https://git.reviewboard.kde.org/r/114910/diff/
Testing
-------
I rebuilt plasma_applet_systemtray.so with the patch and replaced the package
version with it (I'm on Linux Mint 16 KDE, x86_64, KDE 4.11.3). So far I can no
longer reproduce bug 317066 and I don't see any noticeable performance problems
of system tray applet.
Thanks,
Dmitry Ivanov
