> On Feb. 26, 2014, 4:15 p.m., Andrea Iacovitti wrote: > > ... may be it's more clear what I mean in my comments by showing code, see > > http://paste.kde.org/pvzj0ppio > > I did many tests and didn't found issues so far > > > >
No I completely understood your point. It was just that my implementation was from the perspective of I am going to preserve the current functionality and only allow the new POST -> POST redirection when explicitly requested. However, there was no need for that since the behavior in the http ioslave was also changed at the same time. As such I will change KIO's default POST redirection behavior to do POST by default and that override that through the use of the new "redirect-to-get" meta-data. - Dawit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116017/#review50957 ----------------------------------------------------------- On Feb. 26, 2014, 8:34 a.m., Dawit Alemayehu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/116017/ > ----------------------------------------------------------- > > (Updated Feb. 26, 2014, 8:34 a.m.) > > > Review request for kdelibs, Andrea Iacovitti and David Faure. > > > Repository: kdelibs > > > Description > ------- > > The attached patch implements support for redirecting one POST request to > another in KIO. Unless implicitly disabled currently the automatic > redirection handler in KIO always redirects any POST requests to a GET. > > Note this patch also changes the original KIO::http_post implementation that > accepted a QByteArray to simply store the data in a QBuffer and call the > newer implementation that uses a QIODevice. I have updated the documentation > for the original implementation to state as such and encourage developers to > directly use the newer http_post method instead. Not sure if everyone will > agree with my implementation but it makes it much easier to resend POST data > on redirection. > > > Diffs > ----- > > kio/kio/job.h aeaffa2 > kio/kio/job.cpp edc5fed > kio/kio/job_p.h 5ead3ed > kioslave/http/http.cpp 9eba5d1 > > Diff: https://git.reviewboard.kde.org/r/116017/diff/ > > > Testing > ------- > > http://greenbytes.de/tech/tc/httpredirects/t307methods.html > http://greenbytes.de/tech/tc/httpredirects/t308methods.html > > > Thanks, > > Dawit Alemayehu > >
