----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116017/#review51568 -----------------------------------------------------------
This review has been submitted with commit 5fd9d1a7b2d0afda2bf76bcdbd4df5577b893387 by Dawit Alemayehu to branch KDE/4.13. - Commit Hook On Feb. 28, 2014, 5:44 a.m., Dawit Alemayehu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/116017/ > ----------------------------------------------------------- > > (Updated Feb. 28, 2014, 5:44 a.m.) > > > Review request for kdelibs, Andrea Iacovitti and David Faure. > > > Bugs: 330890 > http://bugs.kde.org/show_bug.cgi?id=330890 > > > Repository: kdelibs > > > Description > ------- > > The attached patch implements support for redirecting one POST request to > another in KIO. Unless implicitly disabled currently the automatic > redirection handler in KIO always redirects any POST requests to a GET. > > Note this patch also changes the original KIO::http_post implementation that > accepted a QByteArray to simply store the data in a QBuffer and call the > newer implementation that uses a QIODevice. I have updated the documentation > for the original implementation to state as such and encourage developers to > directly use the newer http_post method instead. Not sure if everyone will > agree with my implementation but it makes it much easier to resend POST data > on redirection. > > > Diffs > ----- > > kio/kio/job.h aeaffa2 > kio/kio/job.cpp edc5fed > kio/kio/job_p.h 5ead3ed > kioslave/http/http.cpp 9eba5d1 > > Diff: https://git.reviewboard.kde.org/r/116017/diff/ > > > Testing > ------- > > http://greenbytes.de/tech/tc/httpredirects/t307methods.html > http://greenbytes.de/tech/tc/httpredirects/t308methods.html > http://www.w3.org/People/Bos/Test/redirect307.html > > > Thanks, > > Dawit Alemayehu > >
