----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118750/#review60124 -----------------------------------------------------------
Ship it! Please NOTICE that i've no mandate in the code section. You've certainly my vote, since the present code is clearly wrong and this patch implies no behavioral change, but please wait whether somebody has to raise a veto (next few workdays) before pushing (though i doubt so) - Thomas Lübking On June 15, 2014, 8:18 a.m., Fabian Kosmale wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/118750/ > ----------------------------------------------------------- > > (Updated June 15, 2014, 8:18 a.m.) > > > Review request for kde-workspace and Andriy Rysin. > > > Repository: kde-workspace > > > Description > ------- > > Prior to this patch, the memory str was pointing to was freed once the ; was > reached. By storing the result of opton.toAscii(), the memory is "kept alive". > > > Diffs > ----- > > plasma-desktop/kcms/keyboard/preview/keysymhelper.cpp 67beb80 > > Diff: https://git.reviewboard.kde.org/r/118750/diff/ > > > Testing > ------- > > Only recompiled the application so far. > > > Thanks, > > Fabian Kosmale > >
