----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118750/#review60560 -----------------------------------------------------------
This review has been submitted with commit c77da7f565dc327ddd5b4623eb7ac9074de18c1a by Fabian Kosmale to branch master. - Commit Hook On June 15, 2014, 8:18 a.m., Fabian Kosmale wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/118750/ > ----------------------------------------------------------- > > (Updated June 15, 2014, 8:18 a.m.) > > > Review request for kde-workspace and Andriy Rysin. > > > Repository: kde-workspace > > > Description > ------- > > Prior to this patch, the memory str was pointing to was freed once the ; was > reached. By storing the result of opton.toAscii(), the memory is "kept alive". > > > Diffs > ----- > > plasma-desktop/kcms/keyboard/preview/keysymhelper.cpp 67beb80 > > Diff: https://git.reviewboard.kde.org/r/118750/diff/ > > > Testing > ------- > > Only recompiled the application so far. > > > Thanks, > > Fabian Kosmale > >
