----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119512/#review63309 -----------------------------------------------------------
+1, looks good to me - Martin Klapetek On July 28, 2014, 11:35 a.m., Lukáš Tinkl wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/119512/ > ----------------------------------------------------------- > > (Updated July 28, 2014, 11:35 a.m.) > > > Review request for kdelibs, Aleix Pol Gonzalez and Martin Klapetek. > > > Repository: frameworkintegration > > > Description > ------- > > This patch tries to fix saving/restoring file dialog sizes. Using > KWindowConfig::restoreWindowSize() doesn't work here with the modal exec() > methods. Instead, the patch uses the same method as KDirSelectDialog. > > > Diffs > ----- > > src/platformtheme/kdeplatformfiledialoghelper.h 406a4f1 > src/platformtheme/kdeplatformfiledialoghelper.cpp 520b6f5 > src/platformtheme/kdirselectdialog.cpp 9a4082a > src/platformtheme/kdirselectdialog_p.h 5a8e758 > > Diff: https://git.reviewboard.kde.org/r/119512/diff/ > > > Testing > ------- > > Current Plasma 5, working fine :) > > > Thanks, > > Lukáš Tinkl > >