----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119512/#review63311 -----------------------------------------------------------
src/platformtheme/kdeplatformfiledialoghelper.h <https://git.reviewboard.kde.org/r/119512/#comment44127> this will also hit when the window is shaded, minimized or moved to another virtual desktop (unless the compositor keeps it open for other reasons) src/platformtheme/kdeplatformfiledialoghelper.cpp <https://git.reviewboard.kde.org/r/119512/#comment44128> save|restoreWindowSize is screen size aware (ie. it maintains a different size for a 4k than for a VGA screen in use) If the only issue is the open ::exec() TODO, you might "trick" it by calling ::winId(), then restore the size and ultimately ::exec() Otherwise you could open an own nested eventloop instead of relying on the dialogs exec, but that'd be less elegant. In either case I don't see why bringing your own config re/storage. - Thomas Lübking On Juli 28, 2014, 9:35 vorm., Lukáš Tinkl wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/119512/ > ----------------------------------------------------------- > > (Updated Juli 28, 2014, 9:35 vorm.) > > > Review request for kdelibs, Aleix Pol Gonzalez and Martin Klapetek. > > > Repository: frameworkintegration > > > Description > ------- > > This patch tries to fix saving/restoring file dialog sizes. Using > KWindowConfig::restoreWindowSize() doesn't work here with the modal exec() > methods. Instead, the patch uses the same method as KDirSelectDialog. > > > Diffs > ----- > > src/platformtheme/kdeplatformfiledialoghelper.h 406a4f1 > src/platformtheme/kdeplatformfiledialoghelper.cpp 520b6f5 > src/platformtheme/kdirselectdialog.cpp 9a4082a > src/platformtheme/kdirselectdialog_p.h 5a8e758 > > Diff: https://git.reviewboard.kde.org/r/119512/diff/ > > > Testing > ------- > > Current Plasma 5, working fine :) > > > Thanks, > > Lukáš Tinkl > >