----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119892/#review65070 -----------------------------------------------------------
Thanks for the patch, but I still think (see bug report) that implementing write support for archive kio slaves and then enable dnd for archives in Dolphin is the better way to achieve this. It will be also better in terms of consistency, because the user can not only drag files and folders onto archives but also paste files and folders into archives - archives will be like "normal" folders. ;) I'm really interested what Frank thinks about it. - Emmanuel Pescosta On Aug. 21, 2014, 11:11 p.m., Arjun Ak wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/119892/ > ----------------------------------------------------------- > > (Updated Aug. 21, 2014, 11:11 p.m.) > > > Review request for KDE Base Apps and KDE Utils. > > > Bugs: 338414 > http://bugs.kde.org/show_bug.cgi?id=338414 > > > Repository: kde-baseapps > > > Description > ------- > > This patch implements the "Add to archive" option, which is shown when a user > drags and drops files onto an existing archive. > > > See also: > https://git.reviewboard.kde.org/r/119890 > https://bugs.kde.org/show_bug.cgi?id=338414 > > > Diffs > ----- > > dolphin/src/views/dolphinview.cpp 02b8815 > dolphin/src/views/draganddrophelper.cpp f8ae0ad > lib/konq/konq_operations.cpp 220a90a > > Diff: https://git.reviewboard.kde.org/r/119892/diff/ > > > Testing > ------- > > > Thanks, > > Arjun Ak > >
