----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119892/#review65469 -----------------------------------------------------------
Thanks for your work on this feature - I think that many users would really appreciate this. I think that Emmanuel's idea to add write support to the kioslave might be worth considering. However, implementing the drop on an archive file which is not opened in the view (i.e., the archive kioslave is not active yet) might be more difficult then maybe? I would suggest to add David Faure as a reviewer to this request - maybe he has an idea what the best solution is. A question concerning your proposed changes in Dolphin's source code: right now, when the user drops items on, e.g., a text file, this will be treated like a drop on the empty space in the view, i.e., the items will be copied/moved/linked to the directory which is shown in the view. With your patch, we would ask KonqOperations to drop the items on the text file, right? Will this result in an error message? I think that we should try to keep the current behavior in that situation, i.e., move/copy/link the dropped items in the directory that contains the text file where the items are dropped. - Frank Reininghaus On Aug. 21, 2014, 9:11 p.m., Arjun Ak wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/119892/ > ----------------------------------------------------------- > > (Updated Aug. 21, 2014, 9:11 p.m.) > > > Review request for KDE Base Apps and KDE Utils. > > > Bugs: 338414 > http://bugs.kde.org/show_bug.cgi?id=338414 > > > Repository: kde-baseapps > > > Description > ------- > > This patch implements the "Add to archive" option, which is shown when a user > drags and drops files onto an existing archive. > > > See also: > https://git.reviewboard.kde.org/r/119890 > https://bugs.kde.org/show_bug.cgi?id=338414 > > > Diffs > ----- > > dolphin/src/views/dolphinview.cpp 02b8815 > dolphin/src/views/draganddrophelper.cpp f8ae0ad > lib/konq/konq_operations.cpp 220a90a > > Diff: https://git.reviewboard.kde.org/r/119892/diff/ > > > Testing > ------- > > > Thanks, > > Arjun Ak > >
