----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120782/#review69117 -----------------------------------------------------------
konqueror/CMakeLists.txt <https://git.reviewboard.kde.org/r/120782/#comment48318> Looks old. Prefer the latest version instead konqueror/CMakeLists.txt <https://git.reviewboard.kde.org/r/120782/#comment48319> KONQUEROR_VERSION is confusing. You shall call it KONQUEROR_LIB_VERSION or whatever doesn't make it sound like konqueror --version will return 5.97 konqueror/CMakeLists.txt <https://git.reviewboard.kde.org/r/120782/#comment48320> Not needed konqueror/CMakeLists.txt <https://git.reviewboard.kde.org/r/120782/#comment48321> should be merged with line 22 or 24 if it's optional konqueror/CMakeLists.txt <https://git.reviewboard.kde.org/r/120782/#comment48322> Already enabled by KDECompilerSettings - Christophe Giboudeaux On oct. 24, 2014, 3:12 après-midi, Dan Vrátil wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/120782/ > ----------------------------------------------------------- > > (Updated oct. 24, 2014, 3:12 après-midi) > > > Review request for KDE Base Apps. > > > Repository: kde-baseapps > > > Description > ------- > > This patch modifies konqueror/CMakeLists.txt so that konqueror can be built > stand-alone (against installed libkonq). > > > Diffs > ----- > > konqueror/CMakeLists.txt 37962ca > konqueror/src/CMakeLists.txt 0f6767f > konqueror/src/konqview.h e98ecba > > Diff: https://git.reviewboard.kde.org/r/120782/diff/ > > > Testing > ------- > > > Thanks, > > Dan Vrátil > >
