----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120782/#review69404 -----------------------------------------------------------
+1 after fixing this last issue. konqueror/CMakeLists.txt <https://git.reviewboard.kde.org/r/120782/#comment48507> Not related to your patch, but the build fails without KDED. It's not really optional - Christophe Giboudeaux On oct. 28, 2014, 3:22 après-midi, Dan Vrátil wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/120782/ > ----------------------------------------------------------- > > (Updated oct. 28, 2014, 3:22 après-midi) > > > Review request for KDE Base Apps. > > > Repository: kde-baseapps > > > Description > ------- > > This patch modifies konqueror/CMakeLists.txt so that konqueror can be built > stand-alone (against installed libkonq). > > > Diffs > ----- > > konqueror/CMakeLists.txt 37962ca > konqueror/config-konqueror.h.cmake PRE-CREATION > konqueror/src/CMakeLists.txt 0f6767f > konqueror/src/konqview.h e98ecba > > Diff: https://git.reviewboard.kde.org/r/120782/diff/ > > > Testing > ------- > > > Thanks, > > Dan Vrátil > >
