El dissabte, 8 d’octubre de 2016, a les 7:49:21 CEST, Ben Cooksley va escriure:
> Hi all,
>
> Just a heads up that at the request of Jaroslaw Staniek, Sysadmin has
> moved the following repositories to KDE Review:
>
> - KDb (kdb)
kdb seems to have some public/exported classes without d-pointer that may make
keeping BC harder, is that on purpose?
You may also want to run clazy over it, there's some interesting things in the
report, i.e.
/home/kdeunstable/kdb/src/parser/generated/KDbToken.h:88:28: warning: Missing
reference on non-trivial type (class KDbToken) [-Wclazy-function-args-by-ref]
inline bool operator==(KDbToken other) const { return v == other.v; }
^
/home/kdeunstable/kdb/src/parser/generated/KDbToken.h:91:28: warning: Missing
reference on non-trivial type (class KDbToken) [-Wclazy-function-args-by-ref]
inline bool operator!=(KDbToken other) const { return v != other.v; }
The full log is at
https://paste.kde.org/pojcgtvh2
in case you're interested, note i'm not asking to "fix" everything, some stuff
is a bit "too much" but having a look at it won't hurt
Cheers,
Albert
