On 10 October 2016 at 23:32, Albert Astals Cid <aa...@kde.org> wrote:
> El dissabte, 8 d’octubre de 2016, a les 7:49:21 CEST, Ben Cooksley va > escriure: > > Hi all, > > > > Just a heads up that at the request of Jaroslaw Staniek, Sysadmin has > > moved the following repositories to KDE Review: > > > > - KDb (kdb) > > kdb seems to have some public/exported classes without d-pointer that may > make keeping BC harder, is that on purpose? > Yes, many of them can be converted. There are some performance-critical points like the ones around drivers and connection. > You may also want to run clazy over it, there's some interesting things in > the report, i.e. > > /home/kdeunstable/kdb/src/parser/generated/KDbToken.h:88:28: warning: > Missing reference on non-trivial type (class KDbToken) > [-Wclazy-function-args-by-ref] > inline bool operator==(KDbToken other) const { return v == other.v; } > ^ > /home/kdeunstable/kdb/src/parser/generated/KDbToken.h:91:28: warning: > Missing reference on non-trivial type (class KDbToken) > [-Wclazy-function-args-by-ref] > inline bool operator!=(KDbToken other) const { return v != other.v; } > > > The full log is at > https://paste.kde.org/pojcgtvh2 > in case you're interested, note i'm not asking to "fix" everything, some > stuff is a bit "too much" but having a look at it won't hurt > > Thanks. Serious warnings will be fixed. Fixing other stuff won't hurt, yes, some stuff like this is a good task for students, will have to find them eventually. The stuff passed Coverity checks not so long ago. So far only gcc and msvc were the compilers in daily use, clang maybe year ago. Cheers, > Albert > -- regards, Jaroslaw Staniek KDE: : A world-wide network of software engineers, artists, writers, translators : and facilitators committed to Free Software development - http://kde.org Calligra Suite: : A graphic art and office suite - http://calligra.org Kexi: : A visual database apps builder - http://calligra.org/kexi Qt Certified Specialist: : http://www.linkedin.com/in/jstaniek