Any other comments or issues to address? Thanks, Devin
On Fri, Oct 21, 2022 at 6:21 PM Albert Astals Cid <aa...@kde.org> wrote: > > El divendres, 21 d’octubre de 2022, a les 23:55:28 (CEST), Devin va escriure: > > > make install doesn't install any icon for me with the current master. > > > > I just checked and indeed, the method I changed to using > > ecm_install_icons doesn't seem to have the behaviour I thought it did. > > I hadn't verified it properly because the icon was already > > preinstalled for me. > > > > I reverted to the prior commit which installed the icon fine (it > > should be installing to > > /usr/share/icons/hicolor/scalable/apps/krecorder.svg), does this not > > work for you on X11? I double checked and the application icon shows > > for me. > > https://invent.kde.org/plasma-mobile/krecorder/-/merge_requests/17 > > Makes it work for me (when starting from the terminal) > > Cheers, > Albert > > > > > Thanks, > > Devin > > > > On Fri, Oct 21, 2022 at 5:08 PM Albert Astals Cid <aa...@kde.org> wrote: > > > El divendres, 21 d’octubre de 2022, a les 23:00:46 (CEST), Devin va > escriure: > > > > > The app doesn't have an icon when run in X11 > > > > > > > > Hmm, the location the icon installed to might be non-standard. I think > > > > I've fixed it on master now by copying the way other KDE apps install > > > > the icon. > > > > > > make install doesn't install any icon for me with the current master. > > > > > > Cheers, > > > > > > Albert > > > >