----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115878/#review50490 -----------------------------------------------------------
src/file/lib/filecustommetadata.cpp <https://git.reviewboard.kde.org/r/115878/#comment35526> why not change the path and name parameters to QByteArray/QString? and value to QByteArray. it would look cleaner if you don't have to use data()/constData() all over the place, just in the implementation. - Thomas Braxton On Feb. 18, 2014, 10:51 p.m., Raphael Kubo da Costa wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/115878/ > ----------------------------------------------------------- > > (Updated Feb. 18, 2014, 10:51 p.m.) > > > Review request for Baloo and Vishesh Handa. > > > Repository: baloo > > > Description > ------- > > File: Add a thin wrapper around different xattr implementations. > > OS X, Linux and some BSDs all support extended file attributes in a way or > another, but the API differs among the operating systems. > > Introduce baloo_getxattr() and baloo_setxattr(), named after the OS X and > Linux APIs for getting and setting extended attributes, to perform the right > calls depending on the operating system. > > These functions accept as parameters the arguments that are common across > all xattr implementations -- this means one cannot pass custom |flags| on > Linux or |options| on OS X, but that should be fine for now as the code was > not doing that anyway. > > > Diffs > ----- > > src/file/lib/autotests/filefetchjobtest.cpp > a738c62a58d29ca092e53702d4852a48634d4315 > src/file/lib/autotests/filemodifyjobtest.cpp > 4ad1a6d2138d9754356a573eaf5f2487fcbe220f > src/file/lib/baloo_xattr_p.h PRE-CREATION > src/file/lib/filecustommetadata.cpp > 3a01520947a324dc1674f304e44eca1ae4a19ed7 > src/file/lib/xattrdetector.cpp e05984e611e8582d0e18d08f93b325381222d280 > > Diff: https://git.reviewboard.kde.org/r/115878/diff/ > > > Testing > ------- > > baloo finally builds on FreeBSD. filefetchjobtest and filemodifyjobtest fail > just like they do on Linux :-) > > > Thanks, > > Raphael Kubo da Costa > >
>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<
