----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115878/ -----------------------------------------------------------
(Updated March 6, 2014, 1:26 a.m.) Review request for Baloo, David Edmundson and Vishesh Handa. Changes ------- Patch v2 is up, making the wrappers take QStrings as arguments and making the diff larger. Repository: baloo Description (updated) ------- OS X, Linux and some BSDs all support extended file attributes in a way or another, but the API differs among the operating systems. Introduce baloo_getxattr() and baloo_setxattr(), named after the OS X and Linux APIs for getting and setting extended attributes, to perform the right calls depending on the operating system. These functions accept as parameters the arguments that are common across all xattr implementations -- this means one cannot pass custom |flags| on Linux or |options| on OS X, but that should be fine for now as the code was not doing that anyway. Additionally, instead of taking raw char and void pointer, these wrappers take QStrings are arguments, which allow us to simplify the calling code and keep the QString->QByteArray->const char* conversions in a single place. Diffs (updated) ----- src/file/lib/autotests/filefetchjobtest.cpp c144f045f708c0541ce2eb9453c17735eda6015f src/file/lib/autotests/filemodifyjobtest.cpp 07842440934fbb20411c8d691e0088981b0e71a5 src/file/lib/baloo_xattr_p.h PRE-CREATION src/file/lib/filecustommetadata.cpp 3a01520947a324dc1674f304e44eca1ae4a19ed7 src/file/lib/xattrdetector.cpp e05984e611e8582d0e18d08f93b325381222d280 Diff: https://git.reviewboard.kde.org/r/115878/diff/ Testing (updated) ------- All tests pass on FreeBSD. Thanks, Raphael Kubo da Costa
>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<
