> On April 9, 2014, 8:46 a.m., Vishesh Handa wrote: > > I'm a little hesitant about this because the user may never see emails as > > KMail only shows the first 8 results or so. The user can scroll but by > > default they will never see the Emails. > > > > Do you think it would make sense interleaving the email results with the > > file ones? > > Vishesh Handa wrote: > s/KMail/Krunner/ > > Eike Hein wrote: > How about we do it like this: > > 1) We fetch max 10 file matches. > 2) We fetch max 10 mail matches. > 3) We combine them based on how much we got, i.e.: If we have 10 for both > we show 5/5; when we have 4/10 we show 4/6, when we have 8/4 we show 8/2, > when we have 2/2 we show 2/2. > > You'd have to be the judge whether the extra search work would offset the > UX benefits. Thoughts?
I should add: A simpler algorithm would be to search for max 5 mail items and then search for as many file items as needed to fill up 10 and list them in files;mails order , but because I don't know about the relative costs of the queries I didn't suggest that. - Eike ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117441/#review55262 ----------------------------------------------------------- On April 9, 2014, 3:39 a.m., Eike Hein wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/117441/ > ----------------------------------------------------------- > > (Updated April 9, 2014, 3:39 a.m.) > > > Review request for Baloo and Vishesh Handa. > > > Repository: baloo > > > Description > ------- > > Raising the ceiling would make the Baloo runner more useful in KRunner > frontends like Homerun and Homerun Kicker. > > While it might make sense for Homerun to use Baloo directly, this: > > a) Isn't currently possible in time for SC 4.13 to be released. > > b) Doesn't prevent users from using either the "KRunner" source in Homerun, > or the "Runner: Desktop Search" source. The former is the only way to get a > combined listing with other KRunner plugins, which might be desirable for > some users. > > c) Some users already have the above in their configs, and Baloo is the > natural upgrade path for them (and in fact, the just-released Homerun 1.2.3 > does this automatically). It'd nice if installing SC 4.13 doesn't degrade > their experience -- and 10 was the ceiling in the old nepomuksearch runner. > > It would be awesome if we could get this in before today's 4.13 tag. > > > Diffs > ----- > > src/runner/baloosearchrunner.cpp b62cb8b > > Diff: https://git.reviewboard.kde.org/r/117441/diff/ > > > Testing > ------- > > > Thanks, > > Eike Hein > >
>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<
