----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117441/ -----------------------------------------------------------
(Updated April 9, 2014, 1:42 p.m.) Review request for Baloo and Vishesh Handa. Changes ------- This: - Looks for 10 mail matches first. - Then looks for as many file matches as needed to fill up 10 depending on the number of mail matches, but bounding the latter to 5. - Then adds the matches in file, mail order, up to 10. Bottom line: If there's plenty of matches of either type it'll show 5/5 as before, otherwise it'll try to fill up the 10 in some other way if it can, but never add more than 10. Repository: baloo Description ------- Raising the ceiling would make the Baloo runner more useful in KRunner frontends like Homerun and Homerun Kicker. While it might make sense for Homerun to use Baloo directly, this: a) Isn't currently possible in time for SC 4.13 to be released. b) Doesn't prevent users from using either the "KRunner" source in Homerun, or the "Runner: Desktop Search" source. The former is the only way to get a combined listing with other KRunner plugins, which might be desirable for some users. c) Some users already have the above in their configs, and Baloo is the natural upgrade path for them (and in fact, the just-released Homerun 1.2.3 does this automatically). It'd nice if installing SC 4.13 doesn't degrade their experience -- and 10 was the ceiling in the old nepomuksearch runner. It would be awesome if we could get this in before today's 4.13 tag. Diffs (updated) ----- src/runner/baloosearchrunner.cpp b62cb8b Diff: https://git.reviewboard.kde.org/r/117441/diff/ Testing ------- Thanks, Eike Hein
>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<
