----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117996/ -----------------------------------------------------------
Review request for Baloo and Milian Wolff. Repository: kfilemetadata Description ------- Add an append(QByteArray) method to the ExtractionResult This way plugins can choose to return the data in utf8 or as a QString, and the clients can either just let the standard QString::fromUtf8 function do its magic, or implement some special handling if they wish. This speeds up the PlainTextExtractor quite a bit (60msec vs 8.3msec) Unfortunately, this meant discarding the extraction of WordCount from the Plain Text extractor. Though considering the speed difference, I think it is worth it. Diffs ----- autotests/indexerextractortests.cpp 6b7c605 autotests/simpleresult.h f3793b5 src/extractionresult.h 76dfe59 src/extractionresult.cpp 9bc7946 src/extractors/plaintextextractor.cpp 5a38857 Diff: https://git.reviewboard.kde.org/r/117996/diff/ Testing ------- Thanks, Vishesh Handa
>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<