----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117996/#review57322 -----------------------------------------------------------
src/extractionresult.cpp <https://git.reviewboard.kde.org/r/117996/#comment39922> OK but then I don't get why you can compile this. You provide a definition of the pure-virtual declaration here, no? That's not going to compile, is it? Generally, I'd say don't make it pure-virtual as you can provide a meaningful default-implementation here... Only for performance reasons would one want to reimplement it after all. - Milian Wolff On May 5, 2014, 2:01 p.m., Vishesh Handa wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/117996/ > ----------------------------------------------------------- > > (Updated May 5, 2014, 2:01 p.m.) > > > Review request for Baloo and Milian Wolff. > > > Repository: kfilemetadata > > > Description > ------- > > Add an append(QByteArray) method to the ExtractionResult > > This way plugins can choose to return the data in utf8 or as a QString, > and the clients can either just let the standard QString::fromUtf8 > function do its magic, or implement some special handling if they wish. > > This speeds up the PlainTextExtractor quite a bit (60msec vs 8.3msec) > > Unfortunately, this meant discarding the extraction of WordCount from > the Plain Text extractor. Though considering the speed difference, I > think it is worth it. > > > Diffs > ----- > > autotests/indexerextractortests.cpp 6b7c605 > autotests/simpleresult.h f3793b5 > src/extractionresult.h 76dfe59 > src/extractionresult.cpp 9bc7946 > src/extractors/plaintextextractor.cpp 5a38857 > > Diff: https://git.reviewboard.kde.org/r/117996/diff/ > > > Testing > ------- > > > Thanks, > > Vishesh Handa > >
>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<
