> On Juli 28, 2014, 12:33 nachm., Kai Uwe Broulik wrote: > > No opinion on the patch but a few coding style issues, see below:
Thank you for your reply. I'm very new in programming qt/kde. I saw we are very close neighbours. I live in waiblingen. > On Juli 28, 2014, 12:33 nachm., Kai Uwe Broulik wrote: > > src/keditcommentdialog.cpp, lines 51-52 > > <https://git.reviewboard.kde.org/r/119511/diff/1/?file=293813#file293813line51> > > > > Prefer compile-time checked connections: > > connect(buttonBox, &QDialogButtonBox::accepted, this, &QDialog::accept); yes! compile-time checked is very nice - Felix ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119511/#review63314 ----------------------------------------------------------- On Juli 28, 2014, 2:27 nachm., Felix Eisele wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/119511/ > ----------------------------------------------------------- > > (Updated Juli 28, 2014, 2:27 nachm.) > > > Review request for Baloo and Vishesh Handa. > > > Repository: baloo-widgets > > > Description > ------- > > I removed KDialog from kcommentwidget. I created a new class > keditcommentdialog. If this way is ok, I will do this for the other dialogs. > > > Diffs > ----- > > src/CMakeLists.txt 9b3a2d3 > src/kcommentwidget.cpp 00f69a9 > src/keditcommentdialog.h PRE-CREATION > src/keditcommentdialog.cpp PRE-CREATION > > Diff: https://git.reviewboard.kde.org/r/119511/diff/ > > > Testing > ------- > > Tested in dolphin > > > Thanks, > > Felix Eisele > >
>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<
