----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119511/#review63341 -----------------------------------------------------------
Looks good! :D src/keditcommentdialog.h <https://git.reviewboard.kde.org/r/119511/#comment44151> Could you please add a new line before this line. src/keditcommentdialog.h <https://git.reviewboard.kde.org/r/119511/#comment44152> Another new line over here pleasse src/keditcommentdialog.cpp <https://git.reviewboard.kde.org/r/119511/#comment44155> A simple 'm_editor = editor' will also work. Or rather it would be easier if you avoid the extra variable and did something like this - m_editor = new QTextEdit(this); m_editor->setText(commentText); .. .. src/keditcommentdialog.cpp <https://git.reviewboard.kde.org/r/119511/#comment44153> Extra whitespace src/keditcommentdialog.cpp <https://git.reviewboard.kde.org/r/119511/#comment44154> ditto - Vishesh Handa On July 28, 2014, 12:27 p.m., Felix Eisele wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/119511/ > ----------------------------------------------------------- > > (Updated July 28, 2014, 12:27 p.m.) > > > Review request for Baloo and Vishesh Handa. > > > Repository: baloo-widgets > > > Description > ------- > > I removed KDialog from kcommentwidget. I created a new class > keditcommentdialog. If this way is ok, I will do this for the other dialogs. > > > Diffs > ----- > > src/CMakeLists.txt 9b3a2d3 > src/kcommentwidget.cpp 00f69a9 > src/keditcommentdialog.h PRE-CREATION > src/keditcommentdialog.cpp PRE-CREATION > > Diff: https://git.reviewboard.kde.org/r/119511/diff/ > > > Testing > ------- > > Tested in dolphin > > > Thanks, > > Felix Eisele > >
>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<
