----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124221/#review81954 -----------------------------------------------------------
According to https://github.com/special/qtbase/blob/master/qtbase/src/dbus/Qt5DBusMacros.cmake the option is "NO_NAMESPACE" As the files are generated just once, number of uses should not matter. I prefer generated files to be left out of version control, but I am fine either way. Thanks for doing all these small changes. - Stefan Brüns On July 1, 2015, 10:59 a.m., Pinak Ahuja wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/124221/ > ----------------------------------------------------------- > > (Updated July 1, 2015, 10:59 a.m.) > > > Review request for Baloo, Stefan Brüns and Vishesh Handa. > > > Repository: baloo > > > Description > ------- > > Also added the proxy classes to source tree instead of generating at build > time mainly beacuse I couldn't figure out how to pass options to > qt5_add_dbus_interface to generate header files without automatic > namespacing. Also we'll be using these classes at various places (GUI > monitor, CLI monitor, tests) so might as well keep them in the source tree. > > > Diffs > ----- > > src/file/baloo_interface.h PRE-CREATION > src/file/baloo_interface.cpp PRE-CREATION > src/file/extractor/app.h 79a3dac > src/file/extractor/extractor_interface.h PRE-CREATION > src/file/extractor/extractor_interface.cpp PRE-CREATION > src/file/extractor/org.kde.baloo.extractor.xml PRE-CREATION > src/file/extractor/org.kde.balooExtractor.xml 03eca16 > src/tools/baloo-monitor/CMakeLists.txt 3c675b0 > src/tools/baloo-monitor/monitor.h b20874c > src/tools/baloo-monitor/monitor.cpp 879e961 > > Diff: https://git.reviewboard.kde.org/r/124221/diff/ > > > Testing > ------- > > > Thanks, > > Pinak Ahuja > >
>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<
