> On July 1, 2015, 2:38 p.m., Stefan Brüns wrote:
> > According to
> > https://github.com/special/qtbase/blob/master/qtbase/src/dbus/Qt5DBusMacros.cmake
> > the option is "NO_NAMESPACE"
> >
> > As the files are generated just once, number of uses should not matter. I
> > prefer generated files to be left out of version control, but I am fine
> > either way.
> >
> > Thanks for doing all these small changes.
The targets where I need to use the proxy classes are in different
subdirectories (and at different levels) so I will have to generate them in
every directory. Maybe I'm missing something really trivial, I tried to
generate the classes in a top level CMakeLists.txt by adding
set(baloo_interface_xml
${CMAKE_SOURCE_DIR}/src/file/org.kde.baloo.file.indexer.xml)
qt5_add_dbus_interface(BALOO_INTERFACE ${baloo_interface_xml} baloo_interface
NO_NAMESPACE)
to a top level CMakeLists.txt and used ${BALOO_INTERFACE} from a lower level
but cmake throws out an error saying it cannot fing baloo_interface.cpp
- Pinak
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124221/#review81954
-----------------------------------------------------------
On July 1, 2015, 10:59 a.m., Pinak Ahuja wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124221/
> -----------------------------------------------------------
>
> (Updated July 1, 2015, 10:59 a.m.)
>
>
> Review request for Baloo, Stefan Brüns and Vishesh Handa.
>
>
> Repository: baloo
>
>
> Description
> -------
>
> Also added the proxy classes to source tree instead of generating at build
> time mainly beacuse I couldn't figure out how to pass options to
> qt5_add_dbus_interface to generate header files without automatic
> namespacing. Also we'll be using these classes at various places (GUI
> monitor, CLI monitor, tests) so might as well keep them in the source tree.
>
>
> Diffs
> -----
>
> src/file/baloo_interface.h PRE-CREATION
> src/file/baloo_interface.cpp PRE-CREATION
> src/file/extractor/app.h 79a3dac
> src/file/extractor/extractor_interface.h PRE-CREATION
> src/file/extractor/extractor_interface.cpp PRE-CREATION
> src/file/extractor/org.kde.baloo.extractor.xml PRE-CREATION
> src/file/extractor/org.kde.balooExtractor.xml 03eca16
> src/tools/baloo-monitor/CMakeLists.txt 3c675b0
> src/tools/baloo-monitor/monitor.h b20874c
> src/tools/baloo-monitor/monitor.cpp 879e961
>
> Diff: https://git.reviewboard.kde.org/r/124221/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Pinak Ahuja
>
>
>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<
