----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125125/#review85084 -----------------------------------------------------------
src/file/mainadaptor.cpp (line 45) <https://git.reviewboard.kde.org/r/125125/#comment58837> This could be a real method call instead, so that it doesn't break when someone renames/removes updateConfig().... (I think you forgot some options when generating this file, but you can also do this by hand, simply by having a more specific type as parent instead of QObject*) - David Faure On Sept. 10, 2015, 5:28 a.m., Pinak Ahuja wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/125125/ > ----------------------------------------------------------- > > (Updated Sept. 10, 2015, 5:28 a.m.) > > > Review request for Baloo, David Faure and Vishesh Handa. > > > Repository: baloo > > > Description > ------- > > Add org.kde.baloo to "/" object. This is the interface is required for the > KCM to function. > > > Diffs > ----- > > src/file/CMakeLists.txt e7794ff > src/file/mainadaptor.h PRE-CREATION > src/file/mainadaptor.cpp PRE-CREATION > src/file/mainhub.cpp 83a70f5 > > Diff: https://git.reviewboard.kde.org/r/125125/diff/ > > > Testing > ------- > > > Thanks, > > Pinak Ahuja > >
>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<
