> On Sept. 10, 2015, 6:38 a.m., David Faure wrote: > > src/file/mainadaptor.cpp, line 45 > > <https://git.reviewboard.kde.org/r/125125/diff/1/?file=402421#file402421line45> > > > > This could be a real method call instead, so that it doesn't break when > > someone renames/removes updateConfig().... > > > > (I think you forgot some options when generating this file, but you can > > also do this by hand, simply by having a more specific type as parent > > instead of QObject*) > > Pinak Ahuja wrote: > This will mainly be a stop gap till, a new version of plasma-desktop is > released, I've put up https://git.reviewboard.kde.org/r/125129/ for review > which moves plasma-desktop to use the new D-Bus API. Still if you want I can > make the changes you're suggesting, but it's highly unlikely someone will > rename those methods.
Well, that's the client side, why here we're talking about the server side. Server side, I would encourage to keep the code (until KF6) for increased compat (who knows which version of KF5 and Plasma5 people are going to mix, just keep compat). So yes I would recommend making that server-side code more robust, it's a quick change. - David ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125125/#review85084 ----------------------------------------------------------- On Sept. 10, 2015, 5:28 a.m., Pinak Ahuja wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/125125/ > ----------------------------------------------------------- > > (Updated Sept. 10, 2015, 5:28 a.m.) > > > Review request for Baloo, David Faure and Vishesh Handa. > > > Repository: baloo > > > Description > ------- > > Add org.kde.baloo to "/" object. This is the interface is required for the > KCM to function. > > > Diffs > ----- > > src/file/CMakeLists.txt e7794ff > src/file/mainadaptor.h PRE-CREATION > src/file/mainadaptor.cpp PRE-CREATION > src/file/mainhub.cpp 83a70f5 > > Diff: https://git.reviewboard.kde.org/r/125125/diff/ > > > Testing > ------- > > > Thanks, > > Pinak Ahuja > >
>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<
