----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126227/#review89141 -----------------------------------------------------------
src/engine/vectorpostingiterator.cpp (line 43) <https://git.reviewboard.kde.org/r/126227/#comment61007> Do you think you could sort the values in the mtime posting iterator before sending it forward, instead of sorting it over here? The VectorPostingIteartor just doesn't seem like the correct place. - Vishesh Handa On Dec. 3, 2015, 2:09 a.m., Xuetian Weng wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/126227/ > ----------------------------------------------------------- > > (Updated Dec. 3, 2015, 2:09 a.m.) > > > Review request for Baloo and Vishesh Handa. > > > Repository: baloo > > > Description > ------- > > Test with > - baloosearch 'modified=>...' -d $HOME > - baloosearch 'modified=>...' > > This two queries should return same result since I only index home folder. > But they are not, because result from mtimedb is not sorted. > > In some other rare case (On my machine, regularly happens to torrent > downloaded files), it could also return duplicate result. not sure if this > should be considered as a indexer bug. > > Sort and remove duplication from the result in VectorPostingIterator when > requesting first result with next(). > > > Diffs > ----- > > src/engine/vectorpostingiterator.cpp 777b7fd > > Diff: https://git.reviewboard.kde.org/r/126227/diff/ > > > Testing > ------- > > No more duplicate result or missing result. > > > Thanks, > > Xuetian Weng > >
>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<
