----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126227/#review89170 -----------------------------------------------------------
If you have the time, some automated tests for this would be fairly awesome as well. I'm a little charry of adding the removal of duplicate entires, it seems like we're patching over a problem instead o figuring out the root cause. src/engine/mtimedb.cpp (line 98) <https://git.reviewboard.kde.org/r/126227/#comment61013> Could you please sort these values as well? This is possible why we are getting duplicates. The WriteTransaction assumes the data is sorted when it gets it. src/engine/mtimedb.cpp (line 142) <https://git.reviewboard.kde.org/r/126227/#comment61014> This can be removed once `get` is sorted. - Vishesh Handa On Dec. 6, 2015, 5:29 a.m., Xuetian Weng wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/126227/ > ----------------------------------------------------------- > > (Updated Dec. 6, 2015, 5:29 a.m.) > > > Review request for Baloo and Vishesh Handa. > > > Repository: baloo > > > Description > ------- > > Test with > - baloosearch 'modified=>...' -d $HOME > - baloosearch 'modified=>...' > > This two queries should return same result since I only index home folder. > But they are not, because result from mtimedb is not sorted. > > In some other rare case (On my machine, regularly happens to torrent > downloaded files), it could also return duplicate result. not sure if this > should be considered as a indexer bug. > > Sort and remove duplication from the result in VectorPostingIterator when > requesting first result with next(). > > > Diffs > ----- > > src/engine/mtimedb.cpp f7283b5 > > Diff: https://git.reviewboard.kde.org/r/126227/diff/ > > > Testing > ------- > > No more duplicate result or missing result. > > > Thanks, > > Xuetian Weng > >
>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<
